prevent file data loss due to replacing an open file handle (partial fix for #5275)#5276
Merged
softhack007 merged 2 commits intomainfrom Jan 5, 2026
Merged
prevent file data loss due to replacing an open file handle (partial fix for #5275)#5276softhack007 merged 2 commits intomainfrom
softhack007 merged 2 commits intomainfrom
Conversation
Contributor
WalkthroughCalls to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
softhack007
changed the title
1 task
DedeHai
reviewed
Jan 5, 2026
DedeHai
approved these changes
Jan 5, 2026
softhack007
added a commit
that referenced
this pull request
Jan 5, 2026
prevent file data loss due to replacing an open file handle (partial fix for #5275) - provides better protection again presets.json corruption.
blazoncek
added a commit
to blazoncek/WLED
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
writeObjectToFile()was re-assigningf(global file handle, file.cpp) without first completing any pending write operations on f.Reassigning a file pointer thats still in use can lead to loss of data and file corruption.
This PR provides a fix by first checking for pending writes (doCloseFile == true) and calling f.close() when needed.
The same protection code is already preset in
readObjectFromFile(), it looks like protectingwriteObjectToFile()was forgotten.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.